Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extension flag in jam pack as a fallback #223

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Apr 11, 2023

Summary

This PR supports using the --extension flag when calling jam pack . At the moment the --extension option is not supported by jam although there is a draft PR for supporting it here: paketo-buildpacks/jam#234

Use Cases

In case of buildpack.toml file is not available, instead of using --buildpack flag to package a buildpack, it fallbacks to using --extension flag in order to package an extension.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner April 11, 2023 15:44
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@sophiewigmore
Copy link
Member

I think we should definitely wait on this PR until paketo-buildpacks/jam#234 lands

@mhdawson
Copy link
Member

Successfully used this in an integration test in https://github.com/nodeshift/ubi-nodejs-extension/pull/35

packagers/jam.go Outdated Show resolved Hide resolved
packagers/jam.go Outdated Show resolved Hide resolved
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle I think this is fine, though I have a couple of minor changes I'd like to see. Once we've updated them I'd be happy to merge.

In general, I don't love the idea of silently selecting buildpack.toml vs extension.toml or silently falling back from one to the other, but I'm having a hard time coming up with a better interface at this time. So I'm happy with this general direction.

@robdimsdale robdimsdale added the semver:minor A change requiring a minor version bump label May 9, 2023
@robdimsdale
Copy link
Member

robdimsdale commented May 9, 2023

@pacostas looks good. Can you fix the lint error? (Comparing fileExists == true can be shortened to just fileExists). Then this PR will be good to once paketo-buildpacks/jam#234 is merged.

Marking as blocked on the upstream jam functionality.

@robdimsdale robdimsdale added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label May 9, 2023
@ForestEckhardt
Copy link
Contributor

@ForestEckhardt ForestEckhardt removed the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Jun 7, 2023
@ForestEckhardt ForestEckhardt merged commit 04ea016 into paketo-buildpacks:main Jun 7, 2023
7 checks passed
@pacostas pacostas deleted the jam-pack-extension branch June 7, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants