-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extension flag in jam pack as a fallback #223
Adding extension flag in jam pack as a fallback #223
Conversation
I think we should definitely wait on this PR until paketo-buildpacks/jam#234 lands |
Successfully used this in an integration test in https://github.com/nodeshift/ubi-nodejs-extension/pull/35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle I think this is fine, though I have a couple of minor changes I'd like to see. Once we've updated them I'd be happy to merge.
In general, I don't love the idea of silently selecting buildpack.toml vs extension.toml or silently falling back from one to the other, but I'm having a hard time coming up with a better interface at this time. So I'm happy with this general direction.
587733c
to
1f4e600
Compare
@pacostas looks good. Can you fix the lint error? (Comparing Marking as |
Summary
This PR supports using the --extension flag when calling
jam pack
. At the moment the --extension option is not supported by jam although there is a draft PR for supporting it here: paketo-buildpacks/jam#234Use Cases
In case of buildpack.toml file is not available, instead of using --buildpack flag to package a buildpack, it fallbacks to using
--extension
flag in order to package an extension.Checklist