Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor wheel package for offline fixture #241

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

thitch97
Copy link
Contributor

@thitch97 thitch97 commented Apr 27, 2023

Summary

Updates vendored packages for offline fixture. Resolves #240

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@thitch97 thitch97 requested a review from a team as a code owner April 27, 2023 19:53
@thitch97
Copy link
Contributor Author

thitch97 commented Apr 27, 2023

Vendoring the missing package from the errors seen in #240 solved the issue but I haven't quite ascertained what changed to cause the failures. I noticed, however, that in #142 the same thing was done for setuptools which gives me a bit of confidence as far as precedent. I haven't had time yet to look into it and the answer may be simple but I wonder why either of those two need to be vendored at all given we bundle them with pip.

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Apr 27, 2023
@robdimsdale
Copy link
Member

I haven't had time yet to look into it and the answer may be simple but I wonder why either of those two need to be vendored at all given we bundle them with pip.

That's my concern too. wheel is bundled with the pip dependency, so why do we need to vendor it again?

@thitch97
Copy link
Contributor Author

thitch97 commented May 1, 2023

@robdimsdale Perhaps we get this change in and create an issue to investigate the need to re-vendor wheel and setuptools? My preliminary investigation didn't point me to anything but I'd be willing to dig into it further.

@robdimsdale
Copy link
Member

Sure. It's probably time for us to dig in a bit deeper to the topic of vendoring wheel, setuptools, etc, but I agree that we should unblock the pipelines.

@robdimsdale robdimsdale enabled auto-merge (rebase) May 1, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline integration tests are failing
2 participants