Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Identity #115

Merged
merged 1 commit into from
Nov 19, 2020
Merged

PR Identity #115

merged 1 commit into from
Nov 19, 2020

Conversation

nebhale
Copy link
Member

@nebhale nebhale commented Nov 18, 2020

Previously when a PR was created the author for the create commit was the "actor" in the action. In actions based on schedules, this actor is the author of the last commit; the commit that the action reads its workflow from. This behavior lead to commits appearing to come from real users rather than the robots that were creating the PRs.

This change updates the author of the created commits to always be the same bot that is creating the PR.

Previously when a PR was created the author for the create commit was the
"actor" in the action.  In actions based on schedules, this actor is the
author of the last commit; the commit that the action reads its workflow from.
This behavior lead to commits appearing to come from real users rather than
the robots that were creating the PRs.

This change updates the author of the created commits to always be the same
bot that is creating the PR.

Signed-off-by: Ben Hale <bhale@vmware.com>
@nebhale nebhale requested a review from a team November 18, 2020 15:36
@nebhale nebhale added semver:patch A change requiring a patch version bump type:enhancement A general enhancement labels Nov 18, 2020
@ekcasey ekcasey merged commit e978f7a into main Nov 19, 2020
@ekcasey ekcasey deleted the pr-identity branch November 19, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants