Windows Buildpackages #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
added
semver:minor
nebhale
force-pushed
the
windows-buildpackages
branch
2 times, most recently
from
edba3bf
to
789d17a
Compare
This change adds support for windows buildpackages by adding a Package.Platform descriptor entry. This allows you to declare an OS which, if not specified defaults to "linux". It also enables the pack experimental flag for windows buildpackages. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
force-pushed
the
windows-buildpackages
branch
from
789d17a
to
73da540
Compare
|
This works great for us! We'll be using it with all our new packages, and I'm already trying it out with a few buildpacks of my own. Thank you! |
ekcasey
approved these changes
Nov 20, 2020
This was referenced Dec 18, 2020
ghost
mentioned this pull request
This was referenced Dec 18, 2020
ghost
mentioned this pull request
This was referenced Dec 18, 2020
ghost
mentioned this pull request
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
This was referenced Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for windows buildpackages by adding a Package.Platform descriptor entry. This allows you to declare an OS which, if not specified defaults to "linux". It also enables the pack experimental flag for windows buildpackages.
See pivotal-cf/tanzu-dotnet-framework#25 for an example pipeline.
[resolves #107]