Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Object #94

Merged
merged 1 commit into from
Nov 5, 2020
Merged

GitHub Object #94

merged 1 commit into from
Nov 5, 2020

Conversation

nebhale
Copy link
Member

@nebhale nebhale commented Nov 5, 2020

This change updates the descriptor to take GitHub as an object containing both the username and a token rather than just the token. There are some places where a username is required in addition to the token.

This change updates the descriptor to take GitHub as an object containing both
the username and a token rather than just the token.  There are some places
where a username is required in addition to the token.

Signed-off-by: Ben Hale <bhale@vmware.com>
@nebhale nebhale requested a review from a team November 5, 2020 12:44
@nebhale nebhale added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Nov 5, 2020
@nebhale nebhale merged commit 171d150 into main Nov 5, 2020
@nebhale nebhale deleted the github-object branch November 5, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant