Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures to run acceptance tests/publishing when creating a release #46

Closed
mhdawson opened this issue Feb 27, 2024 · 5 comments
Closed

Comments

@mhdawson
Copy link
Member

Failure here - https://github.com/paketo-community/ubi-base-stack/actions/runs/8070665351/job/22053877535

strange since the tests ran/passed when run on the PR itself.

@pacostas can you take a look?

@pacostas
Copy link
Contributor

pacostas commented Feb 28, 2024

Yeap, opened PR #50 . what was happening, is that the acceptance tests were trying to use a build image that hasnt been downloaded by the workflow.

- name: Download Build Image
uses: actions/download-artifact@v3
with:
name: current-build-image
path: build
- name: Download Run Image
uses: actions/download-artifact@v3
with:
name: current-run-image
path: build
- name: Download nodejs-16 Run Image
uses: actions/download-artifact@v3
with:
name: current-nodejs-16-run-image
path: build-nodejs-16
- name: Download nodejs-18 Run Image
uses: actions/download-artifact@v3
with:
name: current-nodejs-18-run-image
path: build-nodejs-18
- name: Download nodejs-20 Run Image
uses: actions/download-artifact@v3
with:
name: current-nodejs-20-run-image
path: build-nodejs-20
- name: Download java-8 Run Image
uses: actions/download-artifact@v3
with:
name: current-java-8-run-image
path: build-java-8
- name: Download java-11 Run Image
uses: actions/download-artifact@v3
with:
name: current-java-11-run-image
path: build-java-11
- name: Download java-17 Run Image
uses: actions/download-artifact@v3
with:
name: current-java-17-run-image
path: build-java-17
- name: Download java-21 Run Image
uses: actions/download-artifact@v3
with:
name: current-java-21-run-image
path: build-java-21
- name: Run Acceptance Tests
run: scripts/test.sh

As you can see on the workflow we only download the one under the build directory and the tests for each node version were fetching the build-nodejs-xx/build.oci instead of the build/build.oci

@mhdawson
Copy link
Member Author

The acceptance tests pass, but now we fail to upload

X-Xss-Protection: 1; mode=block
{"message":"Validation Failed","request_id":"F080:21909:16425F:1D811D:65E11279","documentation_url":"https://docs.github.com/rest","errors":[{"resource":"ReleaseAsset","code":"already_exists","field":"name"}]}
Retrying in 16.842089869s
  Uploading asset: build-java-21/run.oci -> ubi-base-stack-0.0.37-run-java-21.oci
Error: failed to upload asset: unexpected response: HTTP/2.0 422 Unprocessable Entity

@pacostas any chance this has to do with what we had to change to get the acceptance tests passing in the create release process? If not I'll take a closer look tomorrow.

@mhdawson mhdawson changed the title Failures to run acceptance tests when creating a release Failures to run ~~acceptance tests~~ publishing when creating a release Feb 29, 2024
@mhdawson mhdawson changed the title Failures to run ~~acceptance tests~~ publishing when creating a release Failures to run ~acceptance tests~ publishing when creating a release Feb 29, 2024
@mhdawson mhdawson changed the title Failures to run ~acceptance tests~ publishing when creating a release Failures to run acceptance tests/publishing when creating a release Feb 29, 2024
@pacostas
Copy link
Contributor

pacostas commented Mar 1, 2024

interesting because i didnt change anything on the create and push release except the upgrade of the actions. Im taking a look

@pacostas
Copy link
Contributor

pacostas commented Mar 1, 2024

It was uploading twice the 21 java image and therefore the name was already exist. Opened PR #52 with the fix. It is also tested.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2024

@pacostas thanks, closing as should be resolved now.

@mhdawson mhdawson closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants