Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using build image on all the generated builders on the acceptance/integration tests #50

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

pacostas
Copy link
Contributor

Related issue

Summary

On each release we ship one builder image and multiple run images despite we generate from the create.sh script multiple build.oci images one for each engine, majorVersion. Therefor On our integration/acceptance tests, is uneccesary to test all the build.oci images located under each build-<engine>-<majorVersion> as we:

Use Cases

This PR alters the function utils.GenerateBuilder to always point the builder image to build/build.oci

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas
Copy link
Contributor Author

Acceptance workflow has been tested here https://github.com/pacostas/ubi-base-stack/actions/runs/8081169572/job/22079462874

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 18cc2a1 into paketo-community:main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants