Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exhaustive equal-length bin algorithm #18

Open
willgearty opened this issue Jul 18, 2022 · 1 comment
Open

Exhaustive equal-length bin algorithm #18

willgearty opened this issue Jul 18, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@willgearty
Copy link
Collaborator

It would be nice to have a way to ensure that we have the MOST equal-length bins possible. This could include some sort of algorithm that checks a bunch of different sets of bins and then compares their sds. I'm not sure on the return on investment here, both in terms of developer time and computation time within the function, but I think it might be useful for more statistically-inclined users.

@willgearty willgearty added the enhancement New feature or request label Jul 18, 2022
@LewisAJones
Copy link
Collaborator

Agreed. In reality, the current implementation is probably already giving the user the most equal bins for the specified bin size. I think with an exhaustive method, we could have occasions were more equal time bins are drawn, however the mean bin size will likely be further from the specified bin size. The current implementation is grouping based on a cumulative sum, so it is generally giving you the best grouping for the target bin size. This is just something to be aware of. Maybe in an updated approach, the user wouldn't specify a bin size, and a list of different groupings could be returned with the mean/standard deviation of each. The user would then be able to choose what standard deviation they are happy with for given bin sizes. I would like to hear feedback from the community first though! I think there are different ways to think about these things depending on what you prioritise.

@LewisAJones LewisAJones self-assigned this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants