Added okhttp3 module #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at the mercy of a new Picasso version first)
|
Thanks for contributing! IMO We do not another OkHttp3Module. OkHttp3 support can be added to already existing module. |
|
And I have added OkHttp3 support to OkHttpModule. You can check in |
|
Good point: Since the dependencies are being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of OkHttp's package name change, the current
debugdrawer-okhttpmodule won't work with OkHttp 3.0.0-RC1 and newer. This PR creates a new module,debugdrawer-okhttp3, which uses the latest revision of Square's library and provides anOkHttp3Modulefor usage with DebugDrawer. The demo app doesn't include this yet, since we're at the mercy of a new version of Picasso first, which provides a Downloader using OkHttp3, however this has recently been merged.