Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sync functionality in the web client #84

Closed
palant opened this issue Feb 27, 2018 · 4 comments
Closed

Enable sync functionality in the web client #84

palant opened this issue Feb 27, 2018 · 4 comments

Comments

@palant
Copy link
Owner

palant commented Feb 27, 2018

As implemented in #24, the sync functionality is disabled in the web client. The difficulty is getting the access token. Since we don't know where the web client will be installed (typically, it will even be running from file:///), receiving the access token the usual way won't work. It seems that we'll need to set up a page (https://pfp.works/webclient/redirect_receiver I guess) that will display the access token and let the user copy it into the web client. Unfortunately, it doesn't look like Dropbox provides such a page, not taking the detour via pfp.works would have been better.

@palant
Copy link
Owner Author

palant commented Feb 28, 2018

Interestingly, Google Drive supports urn:ietf:wg:oauth:2.0:oob as redirect URI which allows manual copy and paste. However, it doesn't seem to be supported for the implicit flow which one is bound to use here.

@palant palant closed this as completed in 42f122f Mar 7, 2018
@palant
Copy link
Owner Author

palant commented Mar 7, 2018

This works with Google Drive now. It should be good enough, I'll not set up a redirect receiver from Dropbox if they don't provide one.

@palant
Copy link
Owner Author

palant commented Mar 7, 2018

@palant
Copy link
Owner Author

palant commented Mar 7, 2018

Apparently, Dropbox has the necessary page under https://www.dropbox.com/1/oauth2/display_token - good to know. Reopening, supporting Dropbox in the web client should be easy then.

@palant palant reopened this Mar 7, 2018
palant added a commit that referenced this issue Mar 8, 2018
@palant palant closed this as completed in 13a6328 Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant