Bump feign timeout #2491
Merged
Bump feign timeout #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyk-91
approved these changes
Oct 16, 2017
| // add some padding to the feign timeout, as in many cases lock requests default to a 60 second timeout, | ||
| // and we don't want it to exactly align with the feign timeout | ||
| private static final Request.Options DEFAULT_FEIGN_OPTIONS = new Request.Options( | ||
| 10_000, 65_000); |
There was a problem hiding this comment.
I guess we don't have a reference to the default lock request timeout (AtlasDbConstants.DEFAULT_TRANSACTION_LOCK_ACQUIRE_TIMEOUT_MS) so it's inconvenient to try to perform math on that.
Codecov Report
@@ Coverage Diff @@
## develop #2491 +/- ##
==========================================
Coverage ? 60.02%
Complexity ? 4656
==========================================
Files ? 860
Lines ? 40112
Branches ? 4070
==========================================
Hits ? 24077
Misses ? 14567
Partials ? 1468
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Fixes #2455
Implementation Description (bullets):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):
This change is