Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #4247

Closed
wants to merge 10 commits into from

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

1.9.0

Type Description Link
Fix Wrap long parameterized types where necessary palantir/gradle-baseline#716
Improvement Allow suppression of the TODO checkstyle check by giving it an ID. Clarify its comment to allow // TODO(username): ... palantir/gradle-baseline#727
Improvement IntelliJ GitHub issue navigation palantir/gradle-baseline#729
Improvement print out suggestion for module dependencies inclusion in useful format palantir/gradle-baseline#733
Fix The checkImplicitDependencies task will no longer suggest a fix of the current project. palantir/gradle-baseline#736, palantir/gradle-baseline#567
Improvement Implement DangerousCompletableFutureUsage errorprone check palantir/gradle-baseline#740

1.10.0

Type Description Link
Improvement Refaster to use execute over submit when the result is ignored palantir/gradle-baseline#741

1.10.1

Type Description Link
Fix Enable applying refaster rules for repos with -Xlint:deprecation palantir/gradle-baseline#742

1.11.0

Type Description Link
Improvement Apply InputStreamSlowMultibyteRead error prone check at ERROR severity palantir/gradle-baseline#749

1.12.0

Type Description Link
Improvement The baseline-idea plugin now generates configuration more closely aligned with Gradle defaults. palantir/gradle-baseline#718
Improvement Apply the suggested fixes for UnusedMethod and UnusedVariable. palantir/gradle-baseline#751
Improvement Refaster stream.sorted().findFirst() into stream.min(Comparator.naturalOrder()) palantir/gradle-baseline#752
Improvement Error prone validation that Stream.sort is invoked on comparable streams palantir/gradle-baseline#753
Improvement DangerousStringInternUsage: Disallow String.intern() invocations palantir/gradle-baseline#754

1.12.1

Type Description Link
Fix Do not apply the suggested fixes for UnusedMethod and UnusedVariable which automaticall remove code with side effects. palantir/gradle-baseline#757

1.13.0

Type Description Link
Improvement Remove errorprone LogSafePreconditionsConstantMessage palantir/gradle-baseline#755
Improvement Disable errorprone Slf4jLogsafeArgs in test code palantir/gradle-baseline#756
Improvement error-prone now detects Duration#getNanos mistakes and bans URL in equals methods palantir/gradle-baseline#758

1.14.0

Type Description Link
Improvement Implement OptionalOrElseThrowThrows to prevent throwing from orElseThrow palantir/gradle-baseline#759

1.15.0

Type Description Link
Improvement LogSafePreconditionsMessageFormat disallows slf4j-style format characters palantir/gradle-baseline#761
Improvement Error Prone LambdaMethodReference check palantir/gradle-baseline#763

1.16.0

Type Description Link
Improvement baseline-circleci no longer integrates with the (deprecated) FindBugs plugin, as a pre-requisite for Gradle 6.0 compatibility. palantir/gradle-baseline#766

1.17.0

Type Description Link
Fix The TypeParameterUnusedInFormals errorprone check is disabled when compiling on Java 13, to workaround an error-prone bug. palantir/gradle-baseline#767
Improvement Publish scm information within POM palantir/gradle-baseline#769

1.17.1

Type Description Link
Fix LambdaMethodReference avoids suggestions for non-static methods palantir/gradle-baseline#771

1.17.2

Type Description Link
Fix Remove pom only dependencies from analysis in checkUnusedDependencies palantir/gradle-baseline#773

1.18.0

Type Description Link
Improvement When computing unused dependencies, compileOnly and annotationProcessor
dependencies are ignored due to false positives as these dependencies
will not appear as dependencies in the generated byte-code, but are in
fact necessary dependencies to compile a given module.
palantir/gradle-baseline#783

1.19.0

Type Description Link
Improvement Disable PreconditionsConstantMessage on gradle plugins palantir/gradle-baseline#790

2.0.0

Type Description Link
Break Add gradle 6.0-20190904072820+0000 compatibiltiy. This raises minimum required version of gradle for plugins from this repo to 5.0. Additionally add '-Werror' and '-Xlint:deprecation' so we can detect compatiblilty issues early palantir/gradle-baseline#791

2.1.0

Type Description Link
Feature Automatically configure the Intellij Eclipse format plugin to use the eclipse formatter palantir/gradle-baseline#794

2.1.1

Type Description Link
Fix Stop applying error prone patches for checks that have been turned off. palantir/gradle-baseline#793

2.2.0

Type Description Link
Improvement baseline-circleci now validates that the rootProject.name isn't the CircleCI default (project) as can interfere with publishing. palantir/gradle-baseline#775
Improvement Remove JGit dependency palantir/gradle-baseline#798

2.2.1

Type Description Link
Fix Don't add whitespace to blank lines inside comments. Fixes #799 palantir/gradle-baseline#800
Fix Eclipse formatter now aligns multicatch so that it passes checkstyle. palantir/gradle-baseline#807

2.2.2

Type Description Link
Fix ClassUniquenessPlugin now checks the runtimeClasspath configuration by default. palantir/gradle-baseline#810

2.3.0

Type Description Link
Improvement SafeLoggingExceptionMessageFormat disallows {} in safelog exception messages palantir/gradle-baseline#815

2.4.0

Type Description Link
Improvement A new StrictUnusedVariable check will catch any unused arguments (e.g. AuthHeaders) to public methods. If you need to suppress this, rename your variable to have an underscore prefix (e.g. s/foo/_foo/) or just run ./gradlew classes -PerrorProneApply to auto-fix palantir/gradle-baseline#819
Improvement Message format checks use instanceof rather than catching palantir/gradle-baseline#821

2.4.1

Type Description Link
Fix Avoid false positives caused by module-info.class when checking class uniqueness palantir/gradle-baseline#823

2.4.2

Type Description Link
Fix Checkstyle tasks only check their own source set and only actual java sources. They don't look in your src/*/resources directory anymore. palantir/gradle-baseline#830

2.4.3

Type Description Link
Fix Add link to StrictUnusedVariable that directs users to baseline repo. palantir/gradle-baseline#829
Fix Long try-with-resources statements are now aligned such that the first assignment stays on the first line. palantir/gradle-baseline#835

2.5.0

Type Description Link
Improvement Error Prone StringBuilderConstantParameters. StringBuilder with a constant number of parameters should be replaced by simple concatenation. The Java compiler (jdk8) replaces concatenation of a constant number of arguments with a StringBuilder, while jdk 9+ take advantage of JEP 280 (https://openjdk.java.net/jeps/280) to efficiently pre-size the result for better performance than a StringBuilder. palantir/gradle-baseline#832

2.6.0

Type Description Link
Fix Excavator PRs that apply other refaster rules (e.g. Witchcraft ones) will not also apply baseline refaster rules. palantir/gradle-baseline#827
Improvement Added a new ErrorProne check PreferAssertj to assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency on org.assertj:assertj-core in modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used, PreferAssertj may be explicitly disabled to prevent future upgrades from attempting to re-run the migration. palantir/gradle-baseline#841

2.7.0

Type Description Link
Improvement StrictUnusedVariable now ignores variables prefixed with _ and the suggested fix will rename all unused parameters in public methods instead of removing them palantir/gradle-baseline#833
Improvement ErrorProne will now detect dangerous usage of @RunWith(Suite.class) that references JUnit5 classes, as this can cause tests to silently not run! palantir/gradle-baseline#843

2.8.0

Type Description Link
Fix PreferAssertj provides better replacements fixes palantir/gradle-baseline#850
Improvement Do not run error prone on any code in the build directory palantir/gradle-baseline#853

2.8.1

Type Description Link
Fix Fix hamcrest arrayContainingInAnyOrder conversion palantir/gradle-baseline#859

To enable or disable this check, please contact the maintainers of Excavator.

@gmaretic
Copy link
Contributor

gmaretic commented Oct 8, 2019

Feels like we diverged too much to continue this work. @felixdesouza to try again on develop :)

@gmaretic gmaretic closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range scanning on VAR_STRING should be caught at schema generation, rather than producing a runtime log error
3 participants