-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBT] Retry flaky tests #6541
[CBT] Retry flaky tests #6541
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify the annotations for LWVIT, unless you've chosen those specific test methods for a reason!
@@ -128,6 +128,7 @@ public void before() { | |||
LockWatchIntegrationTestUtilities.awaitTableWatched(txnManager, TABLE_REF); | |||
} | |||
|
|||
@ShouldRetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can put this at the class-level? (It seems like this is on almost all if not all the methods.) You can override this to be 15 specifically on that one test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already on this class which I've missed!
Overriding to 15 for all tests given that it retries for all the tests
@ShouldRetry | ||
@Test | ||
public void dynamicRandomColumns() { | ||
ThreadLocalRandom random = ThreadLocalRandom.current(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to circle, this succeeds 80% of the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.