[CBT] Split test into multiple workflows #6555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ergo14
commented
May 1, 2023
•
ergo14
commented
- With this, one failed container will flag the job as failed as soon as that container fails. This will show up on github and alert devs.
- This will still not cancel the other containers. All workflows will still run. Defining each container job separately as a workflow does not change this (i.e. as opposed to what this PR does which is use matrix jobs)
- It might be possible to get the cancelling behavior we want if we add a dummy job that depends on all tests. This has the extra cost of spinning up a new VM for nothing.
jeremyk-91
approved these changes
May 10, 2023
| @@ -52,14 +52,14 @@ done | |||
|
|
|||
| # Short circuit the build if it's docs only | |||
| if ./scripts/circle-ci/check-only-docs-changes.sh; then | |||
| if [ $CIRCLE_NODE_INDEX -eq 0 ]; then | |||
| if [ $1 -eq 0 ]; then | |||
There was a problem hiding this comment.
while I agree that your change means that we reference the first arg of this script as opposed to the env variable, I think it's preferable to declare a variable in the script and then use it in named form elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.