Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code #2

Merged
merged 48 commits into from
Jan 10, 2023
Merged

Initial code #2

merged 48 commits into from
Jan 10, 2023

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Jan 9, 2023 •
edited
Loading

Before this PR

There is no code in the repo.

After this PR

==COMMIT_MSG==
Initial implementation.
==COMMIT_MSG==

See the readme or tests for an example.

I've tried it out on a real life project here.

Possible downsides?

@CRogers
Walking skeleton
68300d9
@CRogers
Groovy for readability
1ad36bc
@CRogers
A gosh-darn real test
fe20d70
@CRogers
Amazing
dca2cc5
@CRogers
Another test
3e226ea
@CRogers
Generate WorkAction
a930629
@CRogers
Refactor
4cb5e64
@CRogers
Product task impl
ff1ae97
@CRogers
refactor
165608f
@CRogers
Add public class name
7e85b17
@CRogers
Correct tests
5a8019a
@CRogers
execute -> action
d313e8e
@CRogers
Latest supported source version
ee36a6d
@CRogers
Extract out annotation to it's own package
a79b25d
@CRogers
Checked in tests
b63aa73
@CRogers
Tests working
c048ba7
@CRogers
Proper integ test
b5a06ea
@CRogers
Fix the test
b061db6
@CRogers
test all the props
db703e7
@CRogers
Rename to CheckedInTests
4dbb300
@CRogers
Recreate tests
b917343
@CRogers
source retention
54878e7
@CRogers
Add @generated
e8d65a0
@CRogers
Let's start writing some better error messages
28e3fd2
@CRogers
must be interface
a144c27
@CRogers
new test + refactor
6206885
@CRogers
Try using parameterised tests
4154e98
@CRogers
Revert "Try using parameterised tests"
d04f5c6 
This reverts commit 4154e98.
@CRogers
Ensure there is an action method
ff42ff9
@CRogers
Fix test
59176e5
@changelog-app
Copy link

changelog-app bot commented Jan 9, 2023 •
edited by CRogers
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Initial implementation.

Check the box to generate changelog(s)

  • Generate changelog entry

CRogers and others added 2 commits January 9, 2023 18:23
@CRogers
Merge pull request #3 from palantir/ckozak/track_originating_elements
fd1aecf 
Track originating elements for incremental compilation
@CRogers
PR comments
07c9b10
carterkozak
carterkozak approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@CRogers
Copy link
Contributor Author

CRogers commented Jan 10, 2023

👍

@CRogers
Copy link
Contributor Author

CRogers commented Jan 10, 2023

dozer?

@CRogers CRogers merged commit ec812e6 into develop Jan 10, 2023
@CRogers CRogers deleted the callumr/initial-code branch January 10, 2023 14:29
@CRogers CRogers restored the callumr/initial-code branch January 10, 2023 14:32
@CRogers CRogers mentioned this pull request Jan 10, 2023
Merged
@CRogers CRogers deleted the callumr/initial-code branch January 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CRogers @carterkozak @svc-changelog