Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons16 font is removed from the font-family of the body tag #1107

Closed
jackkainov opened this issue May 17, 2017 · 3 comments
Closed

Icons16 font is removed from the font-family of the body tag #1107

jackkainov opened this issue May 17, 2017 · 3 comments

Comments

@jackkainov
Copy link

Bug report

  • Package version(s): @blueprintjs/core@1.17.1

While using blueprint with webpack and css-loader, which uses css-nano for minification, font "Icons16" is removed from the body tag.

Css nano has a rule removeAfterKeyword
Which will remove Icons16, because it stands after sans-serif in $pt-font-family variable.
https://github.com/ben-eb/postcss-minify-font-values

The fix is simple - put Icons16 before sans-serif

@llorca
Copy link
Contributor

llorca commented May 17, 2017

I'm pretty sure I remember us explicitly putting Icons16 last for a reason but can't remember right now -- @giladgray should know the answer!

@giladgray
Copy link
Contributor

Icons16 is in there so you can use icon unicode strings in your text. i figured it belongs in last place, but if it works correctly in penultimate place then let's just do that. this issue has come up before, sounds like #1060.

@jackkainov
Copy link
Author

jackkainov commented May 19, 2017

Hi. Yes, sounds like exactly #1060, although i dig a little bit father and found an issue in using css-nano for styles minifying. I've solved an issue by explicitly putting font-family with Icons16 font. If a different order, accepted by default by minifies works for you too, then would be nice to change that and eliminate such issues posted here in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants