Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles incorrect for Checkbox within Radio #1231

Closed
nackner opened this issue Jun 13, 2017 · 3 comments
Closed

Styles incorrect for Checkbox within Radio #1231

nackner opened this issue Jun 13, 2017 · 3 comments

Comments

@nackner
Copy link

nackner commented Jun 13, 2017

Bug report

  • Package version(s): 1.13.0
  • Browser and OS versions: Chrome

Steps to reproduce

            <Radio
                 ...
            >
                ...
                <Checkbox
                     ...
                />
                ...
            </Radio>

Actual behavior

Checkbox looks like a radio button

Expected behavior

Checkbox looks like a checkbox

@llorca llorca added this to the 1.20.0 milestone Jun 13, 2017
@llorca llorca self-assigned this Jun 13, 2017
@giladgray
Copy link
Contributor

giladgray commented Jun 13, 2017

@nackner this is not a valid usage of these two HTML inputs and is unsupported by both Blueprint and the browser. Why are you trying to put one control inside another?

@nackner
Copy link
Author

nackner commented Jun 13, 2017

Closing out per discussion off thread.

@nackner nackner closed this as completed Jun 13, 2017
@giladgray
Copy link
Contributor

result of discussion: don't nest inputs cuz it'll never work right (nested labels cause weird click behavior). instead, do some custom styling so it looks like checkbox is nested inside radio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants