Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 when selecting docs version. #129

Closed
djjonno opened this issue Nov 13, 2016 · 2 comments
Closed

404 when selecting docs version. #129

djjonno opened this issue Nov 13, 2016 · 2 comments
Assignees
@giladgray
Labels
P1 Type: bug
Milestone
1.1.0

Comments

@djjonno
Copy link

djjonno commented Nov 13, 2016

screen shot 2016-11-13 at 7 05 35 pm

screenshot 2016-11-13 07 06 00
@cyu06
Copy link
Contributor

cyu06 commented Nov 13, 2016

In #64, we're still deciding how to host the older versions of the docs so that in the future rather than the 404 you flag, it'll show prior versions.

@giladgray giladgray added this to the 1.1.0 milestone Nov 13, 2016
@adidahiya
Copy link
Contributor

Based on the proposal we agreed upon in #64, we should probably remove this version switcher for now -- we only have one major version published.

One thing that will help document our APIs going forward is supporting a the @since JSDoc flag in our props tables so that users will know about API fields added in minor versions.

giladgray pushed a commit that referenced this issue Nov 15, 2016
hide versions menu if there's only one version
a9793a5 
closes #129, until the next major version 😄
@giladgray giladgray mentioned this issue Nov 15, 2016
Merged
1 task
giladgray added a commit that referenced this issue Nov 15, 2016
@giladgray
remove docs versions selector (#162)
9a51440 
* docs-versions outputs latest release of each major version

* hide versions menu if there's only one version

closes #129, until the next major version 😄

* slightly shorter usage by reducing array directly
@giladgray giladgray self-assigned this Nov 15, 2016
@giladgray giladgray mentioned this issue Nov 22, 2016
Merged
greglo pushed a commit to greglo/blueprint that referenced this issue Dec 12, 2016
@giladgray
remove docs versions selector (palantir#162)
201bbb0 
* docs-versions outputs latest release of each major version

* hide versions menu if there's only one version

closes palantir#129, until the next major version 😄

* slightly shorter usage by reducing array directly
@snyk-bot snyk-bot mentioned this issue Apr 20, 2021
Merged
@snyk-bot snyk-bot mentioned this issue May 13, 2021
Merged
This was referenced Jun 8, 2021
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Jun 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
P1 Type: bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@giladgray @adidahiya @djjonno @cyu06