Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portal] Switch from unstable_renderSubtreeIntoContainer() to unstable_createPortal() for compatibility with React Fiber #1509

Closed
sandys opened this issue Aug 28, 2017 · 1 comment
Closed

[Portal] Switch from unstable_renderSubtreeIntoContainer() to unstable_createPortal() for compatibility with React Fiber #1509

sandys opened this issue Aug 28, 2017 · 1 comment
Labels
Package: core Type: task

Comments

@sandys
Copy link

sandys commented Aug 28, 2017

we are facing the same issues as mentioned here - reactjs/react-modal#484 and facebook/react#9808 (comment)

need to replace unstable_renderSubtreeIntoContainer with unstable_createPortal
@cmslewis cmslewis changed the title Dialog needs to be fixed for compatibility with fiber [Portal] Switch from unstable_renderSubtreeIntoContainer() to unstable_createPortal() for compatibility with React Fiber Aug 28, 2017
@adidahiya adidahiya mentioned this issue Aug 28, 2017
Closed
3 tasks
@giladgray
Copy link
Contributor

we cannot make this switch until we officially support React 16 #866, which will not happen for several months (until internal apps are ready to make the switch).

i'm going to close this issue in favor of #866 for a single place to track the work.

@cjies cjies mentioned this issue Sep 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: core Type: task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sandys @cmslewis @giladgray