2.0 QE

[llorca]

Aggregating all the issues and regressions that show up in 2.0 release candidates.

Docs

• in "Dialogs", the example dialog body text is 16px instead of the normal 14px UI text, because of a pt-running-text above in the tree

• in "Popovers" (dark theme only), the colored text in position buttons need to be lighter
  

• selected low level nav item no longer updates on page scroll
  

• Color scheme "Copied to clipboard" confirmation has wrong icon (though color palette one is fine)
  

• Some input shadows are cut off again
  
  

• Banner seems to only show when the URL hash is declared but empty (e.g. /index.html#). in some rare cases it appears half cut off as well
  

• "Color aliases" table styles are broken
  

• pages ending with props table lack bottom padding (and have too much top margin) no repro
  

• remove left icon of anchor button example useful to show this case
  

• second alert example should be intent danger
  

• move alignment button group to second column
  

• in "Callouts" & "Radios", broken interface description (only when outside of the docs API overlay)
  
  

• "Collapsible list" & "Context menus" & "Editable text" & "Labels" & "Form groups" & "Overlays" & a bunch of other pages end with almost no padding no repro
  

• "Dialogs" & "Checkboxes" & "Text inputs" pages end with no padding no repro
  

• make this gross links interactive tags instead (blocked on [Tags] Add pt-interactive support #2251)
  

• in "Checkboxes" & "Switches" & "Radios" & "Text input groups", .pt-align-right-style classes shouldn't wrap
  

• in "Navbars", there's a bunch of empty props table. either hide "Props" and "Description" headers, or hide the whole thing
  

Core

• file input button lost shadow (only light theme)
  
• numeric input buttons are no longer sized properly (both light and dark themes)
  

Datetime

• in "Date range picker", wrong color for month selection caret icons
  

• in "Date range picker", wrong alignment for reverse month/year selection
  

• date input shadow is gone
  

• in "Date range picker", mispositioned icon for month selection with disabled calendar
  

• time picker shouldn't have default margins/paddings
  

• in "Date input", "no date" label too close to input
  

• in "Date range input", "no date" label moves on input focus intentional so you can see the label when oppover is open
  

• in "Date range input", focusing the input with a selected range gives broken visuals
  

Table

• for every table example, margin is needed between View source on GitHub and the table
  

• "Editing" example displays a broken table
  

• IRegion doesn't render the proper interface description element
  

• RenderMode shouldn't have a copyright header as interface description
  

• "Reordering" table example displays broken icon
  
  

[sei15]

#2137 Any chance of this getting fixed in the rcs?

[llorca]

@sei15 #2137 isn't a blocker to ship 2.0, so probably not as we're pretty strapped here. but we'd happily accept a contribution if you'd like to take a look at it!

[sei15]

I'll give it a shot

[giladgray]

remaining issues: @cmslewis will tackle the table issues, i'll do the DatePicker caption ones. not gonna worry about the rest today (small docs stuff).

[cmslewis]

@giladgray @llorca FYI if you refresh the page while looking at the Table Features, you see this on page load:

I think the docs app still suffers from a Flash of Unstyled Content bug that's causing the table to mis-measure what "width: 100%" is (amongst other issues, e.g. with popover examples mis-measuring what it means to be horizontally centered in the eventual 740-px wide page).

[giladgray]

@cmslewis that sounds in line with what i've observed. can we add an rAF somewhere to delay the measuring?

[cmslewis]

Working on it.

[cmslewis]

@giladgray this is what it took. 🙄

    public componentWillMount() {
        requestAnimationFrame(() => {
            this.hasDelayedBeforeInitialRender = true;
            this.forceUpdate();
        });
    }

    public render() {
        if (!this.hasDelayedBeforeInitialRender) {
            return null;
        }
        // ...
    }

[giladgray]

filed #2292 for follow up. we did it!