Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading <Button> does not hide text set using React children #572

Closed
greglo opened this issue Jan 30, 2017 · 0 comments
Closed

Loading <Button> does not hide text set using React children #572

greglo opened this issue Jan 30, 2017 · 0 comments
Assignees
@giladgray
Labels
Domain: documentation Package: core
Milestone
1.8.0

Comments

@greglo
Copy link
Contributor

greglo commented Jan 30, 2017

The following code snippet renders the button shown.

<Button isLoading={true}>Create collection</Button>

image

Expected:
It hides the text, as if the text was set using the text prop. (Or update the docs to mention that the only supported way is using the prop, not children)
@llorca llorca added this to the 1.8.0 milestone Jan 30, 2017
@giladgray giladgray self-assigned this Jan 30, 2017
giladgray pushed a commit that referenced this issue Jan 30, 2017
wrap string children in span so loading can hide them (fixes #572)
714593b
@giladgray giladgray mentioned this issue Jan 30, 2017
Merged
giladgray added a commit that referenced this issue Jan 31, 2017
@giladgray
Fix loading Button children (#580)
2b505af 
* add docs for Button type prop (fixes #571)

* wrap string children in span so loading can hide them (fixes #572)
@giladgray giladgray mentioned this issue Feb 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giladgray giladgray

Labels
Domain: documentation Package: core
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
3 participants
@llorca @giladgray @greglo