Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangeInput2: timePickerProps defaultValue is ignored #5825

Open
danicase opened this issue Jan 5, 2023 · 0 comments
Open

DateRangeInput2: timePickerProps defaultValue is ignored #5825

danicase opened this issue Jan 5, 2023 · 0 comments

Comments

@danicase
Copy link

danicase commented Jan 5, 2023

Environment

  • Package version(s): 0.9.6
  • Operating System: IOS
  • Browser name and version: Google latest

Code Sandbox

https://codesandbox.io/s/little-dawn-x128py?file=/src/DatetimeExample.tsx

Steps to reproduce

  1. Set the DateTime picker in controlled or uncontrolled mode
  2. set a default time in the timePickerProps
  3. Select dates

Actual behaviour

The default time is set correctly in the time input, but when selecting the dates, it gets ignored.

Expected behaviour

Selecting the date should consider the default time being used.

Possible Solution

On selection, get the time values and apply them to the date selected.

Happy to look into it and open a PR.

Also, I would like to allow the independent setting of timePickerProps. A typical scenario where you want to set a different start and end time. but it is a different topic

@adidahiya adidahiya changed the title DateTimePicker2: timePickerProps defaultValue is ignored DateRangeInput2: timePickerProps defaultValue is ignored Jan 5, 2023
@adidahiya adidahiya self-assigned this Oct 25, 2023
@adidahiya adidahiya removed their assignment Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants