[datetime] fix(DateRangePicker): use timePickerProps.defaultValue correctly #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Right now there is a bug with the current implementation in this PR. manually-selected times are not being respected in the state change handlers:
|
Add demo to docsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
use state.time as source of truthBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
|
Closing as stale, this work needs to be re-started on the "V3" components in @blueprintjs/datetime2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5825
Checklist
Changes proposed in this pull request:
Fix DateRangePicker state change handlers to account for
timePickerProps.defaultValue, both in the calendar hover interactions and the updated value returned in theonChangecallback.Reviewers should focus on:
Consider addressing #5859 in this same PR...
Screenshot