Bourbon deprecations

[bsr203]

Hi,

just FYI.

since I use the scss directly, and use latest Bourbon, I see this warning. Hope you will address before next major release of Bourbon

WARNING: [Bourbon] [Deprecation] `background` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:7, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:114, in mixin `pt-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:201

WARNING: [Bourbon] [Deprecation] `_linear-gradient-parser` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/helpers/_linear-gradient-parser.scss:3, in function `_linear-gradient-parser`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:29, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:114, in mixin `pt-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:201

WARNING: [Bourbon] [Deprecation] `background` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:7, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:139, in mixin `pt-button-hover`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:120, in mixin `pt-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:201

WARNING: [Bourbon] [Deprecation] `_linear-gradient-parser` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/helpers/_linear-gradient-parser.scss:3, in function `_linear-gradient-parser`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:29, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:139, in mixin `pt-button-hover`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:120, in mixin `pt-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:201

WARNING: [Bourbon] [Deprecation] `background` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:7, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:200, in mixin `pt-dark-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:220

WARNING: [Bourbon] [Deprecation] `_linear-gradient-parser` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/helpers/_linear-gradient-parser.scss:3, in function `_linear-gradient-parser`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:29, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:200, in mixin `pt-dark-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:220

WARNING: [Bourbon] [Deprecation] `background` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:7, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:236, in mixin `pt-dark-button-hover`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:215, in mixin `pt-dark-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:220

WARNING: [Bourbon] [Deprecation] `_linear-gradient-parser` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/helpers/_linear-gradient-parser.scss:3, in function `_linear-gradient-parser`
	node_modules/bourbon/app/assets/stylesheets/css3/_background.scss:29, in mixin `background`
	node_modules/@blueprintjs/core/src/common/_mixins.scss:38, in mixin `linear-gradient-with-fallback`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:236, in mixin `pt-dark-button-hover`
	node_modules/@blueprintjs/core/src/components/button/_common.scss:215, in mixin `pt-dark-button`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:220

WARNING: [Bourbon] [Deprecation] `strip-units` is deprecated and will be removed in 5.0.0. Use the renamed `strip-unit` function instead.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_strip-units.scss:17, in function `strip-units`
	node_modules/@blueprintjs/core/src/common/_icons.scss:50, in mixin `pt-icon`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:231

WARNING: [Bourbon] [Deprecation] `placeholder` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_placeholder.scss:2, in mixin `placeholder`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:99, in mixin `pt-input`
	app/..../blueprintjs/react-select/_control.scss:121

WARNING: [Bourbon] [Deprecation] `placeholder` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_placeholder.scss:2, in mixin `placeholder`
	node_modules/@blueprintjs/core/src/components/forms/_common.scss:148, in mixin `pt-dark-input`
	app/..../blueprintjs/react-select/_control.scss:127

WARNING: [Bourbon] [Deprecation] `strip-units` is deprecated and will be removed in 5.0.0. Use the renamed `strip-unit` function instead.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_strip-units.scss:17, in function `strip-units`
	node_modules/@blueprintjs/core/src/common/_icons.scss:50, in mixin `pt-icon`
	app/..../blueprintjs/react-select/_control.scss:238

WARNING: [Bourbon] [Deprecation] `animation` is deprecated and will be removed in 5.0.0. We suggest using an automated prefixing tool, like Autoprefixer.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:10, in mixin `-bourbon-deprecate`
	node_modules/bourbon/app/assets/stylesheets/_bourbon-deprecate.scss:17, in mixin `-bourbon-deprecate-for-prefixing`
	node_modules/bourbon/app/assets/stylesheets/css3/_animation.scss:5, in mixin `animation`
	app/..../blueprintjs/react-select/_control.scss:260

WARNING: [Bourbon] [Deprecation] `strip-units` is deprecated and will be removed in 5.0.0. Use the renamed `strip-unit` function instead.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_strip-units.scss:17, in function `strip-units`
	node_modules/@blueprintjs/core/src/common/_icons.scss:50, in mixin `pt-icon`
	node_modules/@blueprintjs/core/src/components/tag/_common.scss:93, in mixin `tag-remove`
	app/..../blueprintjs/react-select/_multi.scss:42

WARNING: [Bourbon] [Deprecation] `strip-units` is deprecated and will be removed in 5.0.0. Use the renamed `strip-unit` function instead.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_strip-units.scss:17, in function `strip-units`
	node_modules/@blueprintjs/core/src/common/_icons.scss:23, in mixin `pt-icon-sized`
	node_modules/@blueprintjs/core/src/components/tag/_common.scss:125, in mixin `tag-remove-large`
	app/..../blueprintjs/react-select/_multi.scss:67

[patresk]

+1

[giladgray]

the latest-latest Bourbon releases seem to address the deprecation warnings:

• 4.3.1: Internal Bourbon deprecation warnings will no longer be thrown. (Suppress deprecation warnings when called from bourbon thoughtbot/bourbon#1002)
• 4.3.2: Internal Bourbon deprecation warnings for unpack and is-length will no longer be thrown when using the position mixin. (Continuation of #1002, add _position to deprecation whitelist thoughtbot/bourbon#1004)

https://github.com/thoughtbot/bourbon/releases

edit: updated locally and the warnings above persist.

[giladgray]

@bsr203 are you using a Bourbon 5.0 beta release?

we will not be upgrading to 5.0 until it is officially released. but actually we use very little of bourbon, really just position(), so we may consider dropping the dependency entirely.

[giladgray]

I have created PR #719 to resolve most of the warnings. The only remaining warning is about strip-units being renamed in 5.0.

In that PR I also set the handy $output-bourbon-deprecation-warnings Bourbon variable to false so warnings will no longer be logged at all. If you want to see them when importing Blueprint, you'll have to reset this variable to true.

[bsr203]

@giladgray sorry, just saw your message.

I am using "bourbon": "^4.3.2",, I guess it was the current version when I installed. I saw your pull request also updated to the same.