Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Continuation of #1002, add _position to deprecation whitelist #1004

Closed
wants to merge 1 commit into from

Conversation

caseywebdev
Copy link

What does this PR do?

This PR prevents the internal position function from throwing deprecation warnings because of the use of unpack and is-length.

If this is related to an existing issue, include a link to it as well.

#1001, #1002

Screenshots (if relevant)

When using @include positon(...) in v4.3.1...

WARNING: [Bourbon] [Deprecation] `unpack` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_unpack.scss:19, in function `unpack`
	node_modules/bourbon/app/assets/stylesheets/addons/_position.scss:32, in mixin `position`
	stdin:4

WARNING: [Bourbon] [Deprecation] `is-length` is deprecated and will be removed in 5.0.0.
Backtrace:
	node_modules/bourbon/app/assets/stylesheets/functions/_is-length.scss:9, in function `is-length`
	node_modules/bourbon/app/assets/stylesheets/addons/_position.scss:44, in mixin `position`
	stdin:4

@tysongach
Copy link
Contributor

Thanks @caseywebdev!

Merged as 5e6f787.

@tysongach tysongach closed this Feb 10, 2017
@tysongach
Copy link
Contributor

We just released v4.3.2 which includes these changes.

@caseywebdev
Copy link
Author

Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants