Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pt-fill in new components #751

Closed
2 of 3 tasks
leebyp opened this issue Mar 1, 2017 · 8 comments · Fixed by #3777
Closed
2 of 3 tasks

Support pt-fill in new components #751

leebyp opened this issue Mar 1, 2017 · 8 comments · Fixed by #3777

Comments

@leebyp
Copy link
Contributor

leebyp commented Mar 1, 2017

  • DateInput
  • NumericInput
  • file upload
@llorca llorca self-assigned this Mar 1, 2017
@llorca llorca added this to the 1.11.0 milestone Mar 1, 2017
@llorca
Copy link
Contributor

llorca commented Mar 1, 2017

I'll take a look at it this week

@orecus
Copy link

orecus commented Mar 3, 2017

Same issue with the <DateInput /> component, would be great if pt-fill was supported on all types of input/form -controls/groups.

@giladgray giladgray changed the title Support pt-fill for file upload markup Support pt-fill in new components Mar 3, 2017
@giladgray giladgray modified the milestones: 1.12.0, 1.11.0 Mar 3, 2017
@giladgray giladgray added the P2 label Mar 6, 2017
@neevany
Copy link

neevany commented Mar 14, 2017

please consider <DateRangeInput/> too.

@llorca
Copy link
Contributor

llorca commented Mar 14, 2017

@giladgray date inputs and date range inputs are wrapped around a .pt-popover-target. That target needs to be width 100% in order for .pt-fill to work, problem is that it's a parent of the control group/input group. Do you see any nice way of supporting .pt-fill for date inputs and date range inputs before we get to #724?

@llorca llorca modified the milestones: 1.12.0, 1.13.0 Mar 15, 2017
@giladgray giladgray modified the milestones: 1.13.0, 1.14.0 Mar 28, 2017
@llorca llorca removed their assignment Mar 29, 2017
@giladgray giladgray removed this from the 1.14.0 milestone Apr 3, 2017
@cetra3
Copy link
Contributor

cetra3 commented Jun 23, 2017

What's the update on this particular request? I've managed to work around it by:

  • Adding width: 100% on pt-popover-target
  • Adding pt-fill to the inputProps of the DateTime component

@cmslewis
Copy link
Contributor

@cetra3 we just haven't prioritized this lately given our limited resources and other concerns. We'd welcome a contribution if you'd like to open a PR!

@llorca
Copy link
Contributor

llorca commented Jun 23, 2017

@cetra3 no update for DateInput yet because of .pt-popover-target. Your workaround is appropriate but won't work for us since not all popover targets should fill their parent by default.
Look out for updates on #724

@cetra3
Copy link
Contributor

cetra3 commented Jun 24, 2017

Thanks for the responses. Yes, I agree, the pt-popover-target change wouldn't be suitable in a general sense, hence the workaround.

If the plan is to refactor the popover as in #724 I think I can hold out until that is solved.

nathanchrs added a commit to nathanchrs/blueprint that referenced this issue Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants