Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Table children to union type for ts 2.3 support #1144

Merged
merged 1 commit into from May 24, 2017

Conversation

cetra3
Copy link
Contributor

@cetra3 cetra3 commented May 24, 2017

Fixes #1143

Checklist

Changes proposed in this pull request:

Allows Typescript 2.3 to be used which changed some of the behaviour of children with React: microsoft/TypeScript#13618

Reviewers should focus on:

Whether this breaks anything in Typescript 2.2

Screenshot

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @cetra3! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! this looks like the issue I was hitting in #1108

@adidahiya
Copy link
Contributor

I tried this out and it works with TS 2.2.2

@adidahiya adidahiya merged commit b00b1d2 into palantir:master May 24, 2017
@cetra3
Copy link
Contributor Author

cetra3 commented May 24, 2017

Ok awesome! Are there any other components that might be affected by this?

@adidahiya
Copy link
Contributor

from a cursory search for React.ReactElement across the codebase... I came across this one:
IHotkeysTarget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants