Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Move focus cell to (0,0) on FULL_TABLE selection #1172

Merged
merged 2 commits into from May 31, 2017
Merged

[Table] Move focus cell to (0,0) on FULL_TABLE selection #1172

merged 2 commits into from May 31, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented May 31, 2017 •
edited

Checklist

  • Include tests

Changes proposed in this pull request:

Move the focus cell to (0, 0) on FULL_TABLE selection (i.e. on click in the top-left corner).

Screenshot

Before:

2017-05-31 09 59 04

After:

2017-05-31 09 59 30

@blueprint-bot
Copy link

Move focus cell to (0,0) on FULL_TABLE selection

Preview: documentation | table
Coverage: core | datetime

gscshoyru
gscshoyru approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@gscshoyru gscshoyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, could have sworn I had this working; not sure how I missed it. Good catch.

@blueprint-bot
Copy link

Add test

Preview: documentation | table
Coverage: core | datetime

@cmslewis cmslewis merged commit 2fe81ad into master May 31, 2017
@cmslewis cmslewis deleted the cl/focus-cell-full-table-selection branch May 31, 2017 20:40
@cmslewis cmslewis mentioned this pull request Jun 1, 2017
Merged
@giladgray giladgray mentioned this pull request Jun 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gscshoyru gscshoyru gscshoyru approved these changes

Assignees
No one assigned
Labels
Package: table Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmslewis @blueprint-bot @gscshoyru