Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Remove custom focus style in minimal state #1389

Merged
merged 1 commit into from Jul 27, 2017
Merged

[Button] Remove custom focus style in minimal state #1389

merged 1 commit into from Jul 27, 2017

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Jul 26, 2017

Fixes #1381

I traced back some old PRs internally, and it looks like we matched focus styles to hover styles before we ever had the FocusStyleManager, which made a lot of sense with regards to accessibility and keyboard navigation. Might be safe to remove now!

This PR removes these custom focus styles. Feels much better IMO.

@blueprint-bot
Copy link

Remove custom focus style in minimal state

Preview: documentation
Coverage: core | datetime

cmslewis
cmslewis reviewed Jul 27, 2017
View reviewed changes
Copy link
Contributor

@cmslewis cmslewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels so much better IMO!

giladgray
giladgray approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@giladgray giladgray merged commit 54e5af8 into master Jul 27, 2017
@giladgray giladgray deleted the al/button-minimal-focus branch July 27, 2017 18:43
@giladgray giladgray mentioned this pull request Jul 28, 2017
Merged
@jkillian
Copy link
Contributor

Thanks for the fix @llorca! 🍰 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmslewis cmslewis cmslewis approved these changes

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@llorca @blueprint-bot @jkillian @cmslewis @giladgray