[Table] Fix onSelection being called too much in controlled mode #1595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1529
Checklist
Changes proposed in this pull request:
Table
no longer invokesonSelection
excessively onmousemove
whenselectedRegions
is controlled.Reviewers should focus on:
selectedRegions
candidate tothis.props.selectedRegions
under the assumption that the prop would contain the last emitted value. That obviously doesn't hold up whenselectedRegions
is controlled.lastEmittedSelectedRegions
instance variable inDragSelectable
. I compare the currentselectedRegions
candidate to this old value to determine whether I should invokeonSelection
again. If the values are deeply equal, I don't invoke.Screenshot