[EditableText] Add extra code to make sure we move scroll position to the end #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra code to make sure we move scroll position to the endPreview: documentation |
|
Can you post a GIF or add a test? EDIT: and/or* |
|
GIF:
I'm not sure how one would go about testing this, exactly -- other than checking that |
|
Looks like it works for me! Chrome & FF |
llorca
approved these changes
Nov 8, 2017
cmslewis
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761
Changes proposed in this pull request:
Set scrollLeft as well as selection position to guarentee that the scroll is correct.
Reviewers should focus on:
I tried, repeatedly, to figure out why setSelectionRange doesn't seem to work properly, for us, in chrome. I... had a lot of trouble playing with it to get it to do it programmatically in any browser. Even using existing examples.
This method of doing it works in chrome, and other browsers, and will make sure we're scrolled to the end when we need to be.