[Popover2] Make sure targetElement exists before trying to call its function #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
approved these changes
Dec 1, 2017
| @@ -383,7 +383,7 @@ export class Popover2 extends AbstractComponent<IPopover2Props, IPopover2State> | |||
|
|
|||
| private updateDarkParent() { | |||
| if (!this.props.inline && this.state.isOpen) { | |||
| const hasDarkParent = this.targetElement.closest(`.${Classes.DARK}`) != null; | |||
| const hasDarkParent = this.targetElement && this.targetElement.closest(`.${Classes.DARK}`) != null; | |||
There was a problem hiding this comment.
Codebase convention: explicit boolean expression please:
this.targetElement != null && ...
cmslewis
changed the title
Explicit null checkPreview: documentation | landing | table |
cmslewis
previously requested changes
Dec 1, 2017
| @@ -383,7 +383,7 @@ export class Popover2 extends AbstractComponent<IPopover2Props, IPopover2State> | |||
|
|
|||
| private updateDarkParent() { | |||
| if (!this.props.inline && this.state.isOpen) { | |||
| const hasDarkParent = this.targetElement && this.targetElement.closest(`.${Classes.DARK}`) != null; | |||
| const hasDarkParent = this.targetElement !== null && this.targetElement.closest(`.${Classes.DARK}`) != null; | |||
There was a problem hiding this comment.
Oh, you'll want to do double-equals (!=) so that both undefined and null satisfy the condition.
Explicit null check, take two. action!Preview: documentation | landing | table |
cmslewis
reviewed
Dec 1, 2017
| const hasDarkParent = this.targetElement.closest(`.${Classes.DARK}`) != null; | ||
| const hasDarkParent = | ||
| this.targetElement != null && | ||
| typeof this.targetElement !== "undefined" && |
There was a problem hiding this comment.
Line 387 is sufficient without this additional typeof check.
Explicit null check, take threePreview: documentation | landing | table |
adidahiya
approved these changes
Dec 1, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1856
Checklist
Changes proposed in this pull request:
Make sure targetElement exists before trying to call
closeston it