node_modules support for sass imports #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2016 12:28
|
I'm excited for this! just waiting for previews to load before +2'ing |
themadcreator
previously requested changes
Nov 18, 2016
|
yeah something broke with your postcss-copy-assets task... |
this fork does not inline .css files, instead resolving them to relative paths.
|
this has been fixed! @themadcreator you around for a re-review? |
adidahiya
suggested changes
Nov 22, 2016
| @@ -45,7 +45,9 @@ module.exports = (gulp, plugins, blueprint) => { | |||
| )); | |||
|
|
|||
| blueprint.task("sass", "compile", ["icons", "sass-variables"], (project, isDevMode) => { | |||
| const sassCompiler = plugins.sass(); | |||
| const sassCompiler = plugins.sass({ | |||
| importer: require("node-sass-package-importer")({ cwd: project.cwd }), | |||
There was a problem hiding this comment.
please put the require with all the other imports. no reason to do it inline here.
|
lgtm aside from the one comment |
giladgray
dismissed
themadcreator’s stale review
issue resolved but bill is on vacation
adidahiya
approved these changes
Nov 22, 2016
Merged
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* configure node-sass-import to support package names in sass imports instead of relative paths, which break when trying to compile sass APIs outside the monorepo. * update `@import` paths to use `~` prefix * use node-sass-package-importer and "~package" syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
use
node-sass-package-importerto support package names in sass imports instead of relative paths, which break when trying to compile sass APIs outside the monorepo. package paths must begin with the~character, like webpack sass-loader:@import "~@blueprintjs/core/dist/blueprint.css".update relevant
@importpaths.