Fixed broken DateInput close feature due to bumping react-day-select #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
approved these changes
Mar 8, 2018
packages/datetime/src/dateInput.tsx
Outdated
| this.unregisterPopoverBlurHandler(); | ||
| this.lastElementInPopover = lastElement; | ||
| this.lastElementInPopover.addEventListener("blur", this.handlePopoverBlur); | ||
| if (!lastTabbableElement) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2155
Checklist
Changes proposed in this pull request:
Fixed issue caused by bumping react-day-select.
Reviewers should focus on:
The update in react-day-select caused a slight change in behavior. Tabbing inside the date select popover will tab through the month, year selectors, then prev/next month arrow, then the first day of the current month. Prior version focused on the prev and next month's dates ie. days with
DayPicker-Day--outsideclass. Now, after tabbing out of the first day of the current month, the popover will close.Additionally, once the first day is focused, users can move the focused day by using the arrow keys. This PR adds changes which will allow the user to move the focused day and still close the popover by pressing tab anytime.
Screenshot