Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime] caption & examples alignment #2197

Merged
merged 5 commits into from
Mar 7, 2018
Merged

[datetime] caption & examples alignment #2197

merged 5 commits into from
Mar 7, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 3, 2018 •
edited

Fixes #2167

Changes proposed in this pull request:

  • stop measuring year select width in DatePickerCaption cuz it never really changes
  • fix alignment of < > icons in DPC
  • add MomentDate and MomentDateRange in examples to standardize display

daterangeinput-alignment

themadcreator
themadcreator approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@blueprint-bot
Copy link

adjustments after fixing regressions

Preview: documentation | landing | table

@giladgray giladgray merged commit 6bd7e82 into develop Mar 7, 2018
@giladgray giladgray deleted the gg/datetime-examples-alignment branch March 7, 2018 00:26
@giladgray giladgray mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

@llorca llorca Awaiting requested review from llorca

@adidahiya adidahiya Awaiting requested review from adidahiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs typography regressions
3 participants
@giladgray @blueprint-bot @themadcreator