Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all local packages to common externals #2328

Merged
merged 3 commits into from Apr 16, 2018
Merged

add all local packages to common externals #2328

merged 3 commits into from Apr 16, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 28, 2018

addresses #2306, fixes #1805

so they never get bundled in each other.
also use "expanded" externals syntax so the correct name is used for each module system.

so they never get bundled in each other
@blueprint-bot
Copy link

add all local packages to common externals so they never get bundled in each other

Preview: documentation | landing | table

@giladgray
Copy link
Contributor Author

webpack UMD header now looks like this:

"object" == typeof exports && "object" == typeof module 
    ? module.exports = t(require("react"), require("classnames"), require("react-dom"), require("dom4"), require("react-transition-group"), require("@blueprintjs/icons")) 
    : "function" == typeof define && define.amd 
        ? define(["react", "classnames", "react-dom", "dom4", "react-transition-group", "@blueprintjs/icons"], t) 
            : "object" == typeof exports 
                ? exports.Core = t(require("react"), require("classnames"), require("react-dom"), require("dom4"), require("react-transition-group"), require("@blueprintjs/icons")) 
                : (e.Blueprint = e.Blueprint || {}, e.Blueprint.Core = t(e.React, e.classNames, e.ReactDOM, e.window, e.ReactTransitionGroup, e.Blueprint.Icons))

@blueprint-bot
Copy link

use expanded externals syntax

Preview: documentation | landing | table

@blueprint-bot
Copy link

whitespace

Preview: documentation | landing | table

@giladgray giladgray merged commit fd70406 into develop Apr 16, 2018
@giladgray giladgray deleted the gg/externals branch April 16, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack externals configuration is incorrect for commonjs / amd environments
3 participants