Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More modifier props! #2333

Merged
merged 13 commits into from Apr 3, 2018
Merged

More modifier props! #2333

merged 13 commits into from Apr 3, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 29, 2018 •
edited

Follow up from #2329

  • use new modifier props in examples
  • add a bunch of new props:
    • Tag: minimal
    • MenuItem: active
    • TagInput: fill, large
    • NumericInput: fill

@giladgray giladgray requested a review from llorca March 29, 2018 20:40
@blueprint-bot
Copy link

NumericInput fill prop

Preview: documentation | landing | table

llorca
llorca reviewed Mar 29, 2018
View reviewed changes
packages/core/src/components/menu/menuItem.tsx
{
[Classes.ACTIVE]: active,
[Classes.INTENT_PRIMARY]: active && intentClass == null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this too opinionated? seems like a visual change that could be separate from this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorca this is your opinion! when we changed the hover state to gray, we had to go add this intent-primary for the active "selected" state. so this visual change was made long ago.

themadcreator
themadcreator approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good once the build is green

@blueprint-bot
Copy link

use table-dev-app nav props

Preview: documentation | landing | table

@giladgray giladgray merged commit 66bf867 into develop Apr 3, 2018
@giladgray giladgray deleted the gg/modifier-props-2 branch April 3, 2018 18:40
@snyk-bot snyk-bot mentioned this pull request Jan 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llorca llorca llorca approved these changes

@themadcreator themadcreator themadcreator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giladgray @blueprint-bot @llorca @themadcreator