fix Callout icon positioning #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically revert to CSS icon approach where a class on parent adds padding-left and icon is position absolute.
giladgray
commented
Apr 18, 2018
| @@ -26,8 +26,10 @@ Styleguide pt-callout | |||
| position: relative; | |||
| border-radius: $pt-border-radius; | |||
| background-color: rgba($gray3, 0.15); | |||
| width: 100%; | |||
There was a problem hiding this comment.
this fixes some layout issues with callouts in flex containers, where they'd extend waaaay off the edge of the page.
fix Callout icon positioningPreview: documentation | landing | table |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2388
Changes proposed in this pull request:
basically revert to 1.0 CSS icon approach where a class on parent adds padding-left and icon is position absolute.
move
CALLOUT_ICONclass from icon element to callout itself to apply this padding.