-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix input-popover bug in docs #241
Conversation
onChange={this.handleSliderChange} | ||
value={this.state.sliderValue} | ||
/>, | ||
<div style={{ width: "300px" }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awkward; should .pt-slider
just get a min-width instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i think that's the better solution. other inputs set their own widths so slider can follow suit. it'll make everyone's lives easier. there have been other issues reported with slider sizing (i think internally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and did this in a separate, self-contained PR: #266
@adidahiya @giladgray - changed the scope of this PR to just fix the input-popover issue; the slider-popover issue is fixed in the self-contained #266, since it went beyond a simple docs fix. |
@llorca Should we merge this as a quick fix for the rank brokenness of that example, then revisit? Alternative is to leave it in place as a reminder, but I feel like the issue/PR here in Github can track that for us. EDIT: I checked out the preview for #187. That does fix the issue with the input popover. |
i think |
Closed in favor of a better fix with |
PR checklist
What changes did you make?
In the Blueprint docs for
<Popover>
s:autofocus
in the "Input" example to fix a weird scrolling bugIs there anything you'd like reviewers to focus on?