Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-license to BLUEPRINT LICENSE based on Apache 2.0 License #2638

Merged
merged 9 commits into from Jul 9, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jul 2, 2018

Fixes #2602

  1. LICENSE files now declare the license as BLUEPRINT LICENSE based on Apache 2.0 License
    • clarify the role of section 10
    • remove the appendix
  2. package.json files now state "SEE LICENSE"
  3. update README.md license section for the repo itself
  4. mark private packages as SEE LICENSE IN ROOT
    • they are not published to NPM therefore only accessible by checking out repo in which case you have the root LICENSE
  5. add missing LICENSE files to tooling packages

cc @pombredanne, would love to hear what you think of this.

Gilad Gray added 4 commits July 2, 2018 12:47
Clarification that Blueprint has been made available under a modified version of the Apache-2.0. The only modification is an additional section (paragraph 10) in which we ask that you do not pass off any derivative products as Palantir’s products, given that Blueprint is a design toolkit.
@blueprint-bot
Copy link

update readme

Preview: documentation | landing | table

@@ -0,0 +1,192 @@
MODIFIED VERSION OF APACHE LICENSE, VERSION 2.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO you should not make any confusing references to the Apache license in name anywhere in your license text. Call this whatever you want but not a modified Apache 2.0 which brings confusion


Note: Paragraph 10 is the only modification

Original version of Apache License, Version 2.0, is available

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference is also a source of confusion. Remove this IMHO, remove any references to Apache in the license text. And give this license a name that is clearly different like the PALANTIR PUBLIC LICENSE 1.0

If you want to explain somewhere that this is derived from the Apache license, do it in some readme or else. Not in the license text

@pombredanne
Copy link

@giladgray Thanks! I think the modified license text is still confusing and should be cleaned from ANY references to Apache, including URLs and comments that this is based on Apache and that you should give your new license a conspicuous and different name.

Now beside these suggested changes, I still think you are doing yourself a terrible disservice by using using a non-standard "vanity" open source license.

There is nothing I can see as new and material in your added paragraph 10: everything about trademark is covered in section 6 of the standard Apache 2.0 license.

This should raise a red a big flag to any potential and existing user as in any case using a vanity license is like carrying a big sign saying "DO NOT USE THIS CODE".

So that's your choice but this mistake will likely hinder the adoption of your code and projects. And make it harder for users to comply as they will have to review and handle your special terms as an exception.

Copy link

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modified Apache license text is still confusing and potentially misleading

@giladgray
Copy link
Contributor Author

@pombredanne I appreciate your feedback here. Happy to further clarify that this is not the Apache License. We definitely avoid deviating from standard licenses, as can be seen in our other projects on GitHub. But for this particular project, we need to keep this custom license.

@blueprint-bot
Copy link

BLUEPRINT LICENSE

Preview: documentation | landing | table

@@ -57,5 +57,5 @@
"docs"
],
"author": "Palantir Technologies",
"license": "Apache-2.0"
"license": "UNLICENSED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if these packages are not published to npm, we still need to provide a license for when people check out the code from github. So, just add the LICENSE file to these packages and change to "SEE LICENSE FILE"

@blueprint-bot
Copy link

UNLICENSED => SEE LICENSE IN REPO ROOT

Preview: documentation | landing | table

@blueprint-bot
Copy link

missed one

Preview: documentation | landing | table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants