Fix text input Safari cursor issue

[romanr]

Fixes #351

Changes proposed in this pull request:

This is fixed by setting line-height: normal in input field css:

input.pt-input.pt-fill {
    line-height: normal;
}

may also be fixed by line-height: 1; or line-height: 100%; however line-height: normal; is considered the best solution.

[palantirtech]

Thanks for your interest in palantir/blueprint, @romanr! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[giladgray]

the most important thing here is to ensure that text inputs on Chrome, FF, IE, and Edge are unaffected by this change. have you done some cross-browser testing @romanr?

[giladgray]

@romanr also if you enable CircleCI for your fork then we should get a preview comment!

[adidahiya]

Actually I don't think we get @blueprint-bot comments for forks, as I noted here #349 (comment). Worth looking into

[romanr]

Yes, It is Tested OK in FF, Chrome, IE.
We added CircleCI to our fork.

[adidahiya]

Can you push an empty commit to this branch to trigger CI?

[giladgray]

text is noticeably not centered in input fields on all browsers (safari included) after this change:

large inputs seem unaffected and remain centered after removing line-height.

i think the root cause is that 14px font-size produces 11px-tall letters, whereas 16px font-size (large) produces 12px-tall letters. the odd height means it can't ever be centered on the whole pixel which causes the off-by-a-few issue in the screenshot above.

not sure what to do about this... do we just give up and let it be off-center? i'm sure @llorca will have some words about this.

[llorca]

It's more important for the input text to be correctly centered, rather than the Safari cursor.

I'm still on board to try and fix this Safari weirdness if possible, but this solution won't work because it breaks the vertical alignment of text in inputs.

[giladgray]

Closing as we're not ready to accept this fix: the uncentered text makes us very uncomfortable.