[select] fix(QueryList): trim whitespace when creating new items #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[select] fix(QueryList): trim whitespace around query input textPreviews: documentation | landing | table |
|
🙅♂ this is a bad approach, it prevents entering any spaces into the input at all |
|
seems to work fine after merging the latest |
Merge remote-tracking branch 'origin/develop' into ad/fix-multiselectPreviews: documentation | landing | table |
|
just kidding... it's not fixed. it's only MultiSelect which is working as intended now |
trim query when sending to "create new item"Previews: documentation | landing | table |
fix test with new impl behaviorPreviews: documentation | landing | table |
fix lintPreviews: documentation | landing | table |
adidahiya
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3765
Checklist
Changes proposed in this pull request:
QueryList now ignores any whitespace around the input text when reporting changes. Leading/trailing whitespace around controlled query text (supplied through a
queryprop) is still preserved.