Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch symbols #4006

wants to merge 302 commits into from

Sketch symbols #4006

wants to merge 302 commits into from


Copy link

Fixes #0000


  • Sketch elements are symbols now

Changes proposed in this pull request:

Reviewers should focus on:


estevesd and others added 29 commits March 9, 2020 07:34
also run this package's tests in CI properly
 - @blueprintjs/core@3.23.1
 - @blueprintjs/docs-app@3.23.0
 - @blueprintjs/eslint-config@0.2.0
 - @blueprintjs/eslint-plugin-blueprint@0.1.0
 - @blueprintjs/node-build-scripts@1.0.0
 - @blueprintjs/table@3.8.3
 - @blueprintjs/tslint-config@2.0.0
 - @blueprintjs/eslint-config@0.2.1
 - @blueprintjs/node-build-scripts@1.1.0
 - @blueprintjs/core@3.24.0
 - @blueprintjs/docs-app@3.24.0
 - @blueprintjs/icons@3.14.0
 - @blueprintjs/select@3.12.0
* [core] feat(NumericInput): supply input element in onValueChange callback

* small refactor, use optional chaining to invoke callback

* fix lint

* fix more tests

* fix lint, remove describe.only
Allows users to press `DELETE` on their keyboards to delete
an item from `<TagInput />`, which in turn is used by the
`Select` family of components.

Handling `DELETE` to remove item mimics the way `DELETE` works
in a text editor, where an user can delete from the beginning
of the line forward. Reaching the end of the line, in our
case passing the last selected item in `<TagInput />` will stop
deleting. Moving the selection to the first item and deleting
from that point onwards repeatedly will delete all the selected
update INVALID_PROPS list used by removeNonHTMLProps() utility fn
@terpimost terpimost closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet