Skip to content

Sketch symbols - #4006

Closed
terpimost wants to merge 302 commits into
palantir:developfrom
terpimost:sketch-symbols
Closed

Sketch symbols#4006
terpimost wants to merge 302 commits into
palantir:developfrom
terpimost:sketch-symbols

Conversation

@terpimost

Copy link
Copy Markdown
Contributor

Fixes #0000

Checklist

  • Sketch elements are symbols now

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

estevesd and others added 29 commits March 9, 2020 07:34
also run this package's tests in CI properly
 - @blueprintjs/core@3.23.1
 - @blueprintjs/docs-app@3.23.0
 - @blueprintjs/eslint-config@0.2.0
 - @blueprintjs/eslint-plugin-blueprint@0.1.0
 - @blueprintjs/node-build-scripts@1.0.0
 - @blueprintjs/table@3.8.3
 - @blueprintjs/tslint-config@2.0.0
 - @blueprintjs/eslint-config@0.2.1
 - @blueprintjs/node-build-scripts@1.1.0
 - @blueprintjs/core@3.24.0
 - @blueprintjs/docs-app@3.24.0
 - @blueprintjs/icons@3.14.0
 - @blueprintjs/select@3.12.0
* [core] feat(NumericInput): supply input element in onValueChange callback

* small refactor, use optional chaining to invoke callback

* fix lint

* fix more tests

* fix lint, remove describe.only
Allows users to press `DELETE` on their keyboards to delete
an item from `<TagInput />`, which in turn is used by the
`Select` family of components.

Handling `DELETE` to remove item mimics the way `DELETE` works
in a text editor, where an user can delete from the beginning
of the line forward. Reaching the end of the line, in our
case passing the last selected item in `<TagInput />` will stop
deleting. Moving the selection to the first item and deleting
from that point onwards repeatedly will delete all the selected
items.
update INVALID_PROPS list used by removeNonHTMLProps() utility fn
@terpimost terpimost closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.