Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper #4058

Closed
wants to merge 1 commit into from
Closed

Stepper #4058

wants to merge 1 commit into from

Conversation

justinbhopper
Copy link
Contributor

@justinbhopper justinbhopper commented Apr 12, 2020

Adds a new components Stepper, Step, and StepConnector. A stepper is a wizard-like progress indicator.

This PR is not complete due to an issue with compiling docs-data on a windows machine.

I added an example and started work on the docs page, but all of this was done blindly and very may have issues. Help is very much appreciated.

Screenshot

remarkable ai (1)

@justinbhopper
Copy link
Contributor Author

justinbhopper commented Apr 12, 2020

Linting errors are due to wrong line ending settings. My git had autocrlf set to true. Will either fix on this branch if possible, or I will create a new PR.

@justinbhopper
Copy link
Contributor Author

Closing PR - will open a new one with fixes in place.

@adidahiya
Copy link
Contributor

@justinbhopper before you do, can you please open an issue to discuss your API design and feature proposal? We usually don't add big new features to Blueprint like this without a proposal review process. Note that this component has been rejected in the past since we don't really use this design pattern at Palantir, but I'd be open to reconsidering.

@justinbhopper
Copy link
Contributor Author

@adidahiya Of course, I'd be happy to. This was mostly an exercise for me to get the builds working on windows, which I succeeded in doing after some effort.

@adidahiya adidahiya mentioned this pull request Jan 6, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants