Add a docs-theme table for rendering methods #4120
Conversation
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2017 Palantir Technologies, Inc. All rights reserved. | |||
| * Copyright 2020 Palantir Technologies, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Note: this doesn't need to be updated every time a file is edited, it's supposed to show the year when it was created. Please revert this change and the other similar ones in this PR.
There was a problem hiding this comment.
Reverted these thanks
…e docs to include examples of this
@adidahiya Thanks for the feedback adidahiya, I have added some examples for the Table methods https://32525-71939872-gh.circle-artifacts.com/0/packages/docs-app/dist/index.html#table/api.instance-methods and added some logic to include class methods |
| @@ -80,8 +80,7 @@ function transformDocumentalistData(key, value) { | |||
| // reverse the list so highest version is first (easier indexing) | |||
| return Array.from(majors.values()).reverse(); | |||
| } | |||
| // remove all class declarations as they're currently unused and only increase bundle size | |||
| if (value != null && value.kind !== "class") { | |||
There was a problem hiding this comment.
I've had to change this to include the class members but there might be a more efficient way to do it?
| @@ -80,8 +80,7 @@ function transformDocumentalistData(key, value) { | |||
| // reverse the list so highest version is first (easier indexing) | |||
| return Array.from(majors.values()).reverse(); | |||
| } | |||
| // remove all class declarations as they're currently unused and only increase bundle size | |||
| if (value != null && value.kind !== "class") { | |||
Checklist
Changes proposed in this pull request:
Add a table to docs-theme render methods
Use a @method tag to render methods
Reviewers should focus on:
Similar functionality to the interface table but for methods
Screenshot
Before:
After: