Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensured that Alert text does not overflow #4146

Merged
merged 1 commit into from
May 22, 2020
Merged

fix: ensured that Alert text does not overflow #4146

merged 1 commit into from
May 22, 2020

Conversation

isubasinghe
Copy link
Contributor

Fixes #4145

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

add a word-break in for alert-contents

Reviewers should focus on:

Ensuring content inside Alert breaks the large word in order to prevent content from going off
the Alert container.

Screenshot

image

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @isubasinghe! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@isubasinghe isubasinghe reopened this May 22, 2020
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@adidahiya adidahiya merged commit ac0658a into palantir:develop May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert: text overflows if content inside has large word.
3 participants