[core] fix(Collapse): closing animation in Firefox #4186
Conversation
|
Thanks for your interest in palantir/blueprint, @Arbalester! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| this.setTimeout(() => | ||
| this.setState({ | ||
| animationState: AnimationStates.CLOSING, | ||
| height: "0px", | ||
| heightWhenOpen: clientHeight, |
There was a problem hiding this comment.
hmm I'm not sure why this state field is not already set at this time by L222, but this change seems to fix the bug so I'll approve it and look into any potential tweaks later.
There was a problem hiding this comment.
I'll sign the cla in 1-2 days, because my company wants me to sign the corporate version. I'll send it asap
Hi, I've sent on your email signed corporate cla. |
adidahiya
changed the title
Fixes #4114
Checklist
Changes proposed in this pull request:
Changed height for transition. Set 'heightWhenOpen' as content height for the closing process.
Reviewers should focus on: