Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make css side effects work #4331

Merged
merged 1 commit into from Sep 21, 2020
Merged

chore: make css side effects work #4331

merged 1 commit into from Sep 21, 2020

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Sep 12, 2020

The CSS files shipped in the NPM package have a deep path, for example @blueprintjs/core/lib/css/blueprint.css. This PR changes *.css to **/*.css to make it work correctly

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @pd4d10! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya adidahiya merged commit af91a1a into palantir:develop Sep 21, 2020
@adidahiya
Copy link
Contributor

I'm surprised this has gone unnoticed for so long... your change looks correct but are you sure it wasn't working before?

@pd4d10 pd4d10 deleted the patch-1 branch September 21, 2020 16:21
@pd4d10
Copy link
Contributor Author

pd4d10 commented Sep 21, 2020

This issue was found when bundled with rollup, see vitejs/vite#795 (Vite uses rollup under the hood).

It works correctly when bundled with webpack. Perhaps there are some specific strategy to process CSS, I guess.

@adidahiya
Copy link
Contributor

Ok, good to know that this fix is specifically relevant to rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants