Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new icons - array + variants #4352

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

aycai
Copy link
Contributor

@aycai aycai commented Sep 30, 2020

Changes proposed in this pull request:

6 new icons:

  • array
  • bolean array
  • date array
  • numeric array
  • string array
  • timestamp array

Screenshot

Screen Shot 2020-09-30 at 1 00 42 AM

@adidahiya
Copy link
Contributor

preview build

@adidahiya adidahiya merged commit ffa6b98 into palantir:develop Sep 30, 2020
@nrathi
Copy link

nrathi commented Oct 8, 2020

@adidahiya what needs to be done for Classes.iconClass(...) to work for these new icons?

@adidahiya
Copy link
Contributor

@nrathi nothing, Classes.iconClass(iconName: string | undefined) accepts a string, rather than an enum

@nrathi
Copy link

nrathi commented Oct 8, 2020

Ah, it's not working for me :/. It seems like "bp3-icon-numeric" inserts content ::before, but "bp3-icon-array-numeric" doesn't.

@nrathi
Copy link

nrathi commented Oct 8, 2020

Oh nevermind, icon fonts were deprecated her https://blueprintjs.com/docs/#core/components/icon.css.

@adidahiya
Copy link
Contributor

Ah sorry, yeah... the icon font is deprecated, you should use the React components. I'll go ahead and add /** @deprecated */ for more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants