Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icon "layer-outline" #4379

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

MichalPrzybys-TomTom
Copy link
Contributor

Changes proposed in this pull request:

New icon: layer outline

16px: layer-outline
20px: layer-outline-20

Clone of #4358 with Circle-CI disabled

@adidahiya adidahiya requested a review from aycai October 20, 2020 13:39
@adidahiya
Copy link
Contributor

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adidahiya adidahiya changed the title feat: new icon - layer outline [icons] feat: new icon "layer-outline" Oct 20, 2020
@aycai
Copy link
Contributor

aycai commented Oct 20, 2020

Checking the SVGs in both Sketch and Illustrator for redundancy, the points are not even (see pixel values on the top right). I overlaid a stroked version of the icon and it looks like there are still discrepancies. I'll go ahead and make the adjustments since they are reasonably quick later.

20px values

16px values

Copy link
Contributor

@aycai aycai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalPrzybys-TomTom updated the icons as mentioned earlier, should be good to go now.

@adidahiya adidahiya merged commit fd3833e into palantir:develop Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants